Conversation
Collaborator
Author
autarch
changed the base branch from
04-03-tools-4148_replace_waitgroup_tomb_with_an_errgroup_in_ingestdocuments_
to
graphite-base/986
autarch
force-pushed
the
04-03-tools-4148_pass_the_errgroup_created_in_streamdocuments_to_dosequentialstreaming_
branch
from
6a642dc to
a7c9895
Compare
autarch
force-pushed
the
graphite-base/986
branch
from
4b83a4c to
231ee85
Compare
autarch
changed the base branch from
graphite-base/986
to
04-03-tools-4148_replace_waitgroup_tomb_with_an_errgroup_in_ingestdocuments_
autarch
force-pushed
the
04-03-tools-4148_pass_the_errgroup_created_in_streamdocuments_to_dosequentialstreaming_
branch
from
a7c9895 to
6a16202
Compare
autarch
force-pushed
the
04-03-tools-4148_replace_waitgroup_tomb_with_an_errgroup_in_ingestdocuments_
branch
2 times, most recently
from
d8b63da to
20dae74
Compare
autarch
force-pushed
the
04-03-tools-4148_pass_the_errgroup_created_in_streamdocuments_to_dosequentialstreaming_
branch
3 times, most recently
from
21b229e to
bffbbf6
Compare
autarch
force-pushed
the
04-03-tools-4148_replace_waitgroup_tomb_with_an_errgroup_in_ingestdocuments_
branch
from
20dae74 to
ea0773c
Compare
autarch
force-pushed
the
04-03-tools-4148_replace_waitgroup_tomb_with_an_errgroup_in_ingestdocuments_
branch
from
ea0773c to
b51b373
Compare
autarch
force-pushed
the
04-03-tools-4148_pass_the_errgroup_created_in_streamdocuments_to_dosequentialstreaming_
branch
from
bffbbf6 to
4f5e086
Compare
This was referenced Apr 8, 2026
mmcclimon
approved these changes
Apr 8, 2026
mongoimport/common_test.go
Outdated
| //nolint:errcheck | ||
| go iw.processDocuments(t.Context(), true) | ||
| eg.Go( | ||
| func() error { return iw.processDocuments(t.Context(), true) }, |
Contributor
There was a problem hiding this comment.
Suggested change
| func() error { return iw.processDocuments(t.Context(), true) }, | |
| func() error { return iw.processDocuments(ctx, true) }, |
This surely won't matter in practice but is less weird.
autarch
force-pushed
the
04-03-tools-4148_pass_the_errgroup_created_in_streamdocuments_to_dosequentialstreaming_
branch
from
4f5e086 to
4c3fdbb
Compare
Collaborator
Author
autarch
changed the base branch from
04-03-tools-4148_replace_waitgroup_tomb_with_an_errgroup_in_ingestdocuments_
to
graphite-base/986
…ntialStreaming` This removes the last bare `go func` in mongoimport.
autarch
force-pushed
the
04-03-tools-4148_pass_the_errgroup_created_in_streamdocuments_to_dosequentialstreaming_
branch
from
4c3fdbb to
4dc12a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the last bare
go funcin mongoimport.