Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue in Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the websocket initialization to use 'websocket' as the default transport, preventing fallback to long-polling. The implementation is straightforward. I've added a couple of comments: one to correct a link in the CHANGELOG and another to suggest updating the unit tests to reflect the new transport configuration.
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [[5.6.21](https://github.com/multiversx/mx-sdk-dapp/pull/1728)] - 2026-03-11 |
There was a problem hiding this comment.
The pull request link for version [5.6.21] appears to be incorrect. It points to pull request #1728, but the change described below is from pull request #1727. To maintain consistency and correct traceability, the version link should also point to #1727.
| ## [[5.6.21](https://github.com/multiversx/mx-sdk-dapp/pull/1728)] - 2026-03-11 | |
| ## [[5.6.21](https://github.com/multiversx/mx-sdk-dapp/pull/1727)] - 2026-03-11 |
| timeout: TIMEOUT, | ||
| query: { address } | ||
| query: { address }, | ||
| transports: ['websocket'] |
There was a problem hiding this comment.
While this change correctly forces the websocket transport, the corresponding unit test in src/methods/initApp/websocket/tests/initializeWebsocketConnection.test.ts has not been updated to assert this new option. Please update the test to ensure it checks for transports: ['websocket'] in the io call options to prevent future regressions.
For example, the test could be updated as follows:
// in src/methods/initApp/websocket/tests/initializeWebsocketConnection.test.ts
expect(io).toHaveBeenCalledWith(websocketUrl, {
forceNew: true,
reconnection: true,
reconnectionAttempts: 3,
reconnectionDelay: 500,
timeout: 3000,
query: { address: account.address },
transports: ['websocket']
});
Issue/Feature
websockettransport as default on websocket initReproduce
Issue exists on version
2.of sdk-dapp.Root cause
Fix
Additional changes
Contains breaking changes
Updated CHANGELOG
Testing