Skip to content

Websocket Default Transport #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radumojic merged 5 commits into from
Mar 11, 2026
Merged

Websocket Default Transport #1727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4f8039
added transports on websocket init
radumojic Mar 3, 2026
a4990d0
Merge branch 'development' of github.com:multiversx/mx-sdk-dapp into …
radumojic Mar 11, 2026
f4283c3
update Changelog
radumojic Mar 11, 2026
6204f84
update Changelogpackage.json version
radumojic Mar 11, 2026
aa72b2b
fix initializeWebsocketConnection tests
radumojic Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [[5.6.21](https://github.com/multiversx/mx-sdk-dapp/pull/1728)] - 2026-03-11
Copy link

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request link for version [5.6.21] appears to be incorrect. It points to pull request #1728, but the change described below is from pull request #1727. To maintain consistency and correct traceability, the version link should also point to #1727.

Suggested change
## [[5.6.21](https://github.com/multiversx/mx-sdk-dapp/pull/1728)] - 2026-03-11
## [[5.6.21](https://github.com/multiversx/mx-sdk-dapp/pull/1727)] - 2026-03-11


- [Use websocket transport as default on websocket init](https://github.com/multiversx/mx-sdk-dapp/pull/1727)

## [[5.6.20](https://github.com/multiversx/mx-sdk-dapp/pull/1726)] - 2026-03-10

- [Added missing option to skip guardian checks in signTransactions function](https://github.com/multiversx/mx-sdk-dapp/pull/1726)
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@multiversx/sdk-dapp",
"version": "5.6.20",
"version": "5.6.21",
"description": "A library to hold the main logic for a dapp on the MultiversX blockchain",
"author": "MultiversX",
"license": "MIT",
Expand Down
3 changes: 2 additions & 1 deletion src/methods/initApp/websocket/initializeWebsocketConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ export async function initializeWebsocketConnection(address: string) {
reconnectionAttempts: RECONNECTION_ATTEMPTS,
reconnectionDelay: RETRY_INTERVAL,
timeout: TIMEOUT,
query: { address }
query: { address },
transports: ['websocket']
Copy link

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly forces the websocket transport, the corresponding unit test in src/methods/initApp/websocket/tests/initializeWebsocketConnection.test.ts has not been updated to assert this new option. Please update the test to ensure it checks for transports: ['websocket'] in the io call options to prevent future regressions.

For example, the test could be updated as follows:

// in src/methods/initApp/websocket/tests/initializeWebsocketConnection.test.ts
expect(io).toHaveBeenCalledWith(websocketUrl, {
  forceNew: true,
  reconnection: true,
  reconnectionAttempts: 3,
  reconnectionDelay: 500,
  timeout: 3000,
  query: { address: account.address },
  transports: ['websocket']
});

});

websocketConnection.instance.onAny(handleMessageReceived);
Expand Down
3 changes: 2 additions & 1 deletion src/methods/initApp/websocket/tests/initializeWebsocketConnection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ describe('initializeWebsocketConnection tests', () => {
reconnectionAttempts: 3,
reconnectionDelay: 500,
timeout: 3000,
query: { address: account.address }
query: { address: account.address },
transports: ['websocket']
});
expect(mockSocketInstance.onAny).toHaveBeenCalled();
expect(mockSocketInstance.on).toHaveBeenCalledTimes(4);
Expand Down
Loading