Skip to content

Conversation

@DouweM
Copy link

@DouweM DouweM commented Jan 18, 2013

I did some refactoring, plus I made the following significant changes:

  • Wrap cache read/write calls in notification instrumentation for fragment read/write logging.
  • Use correct template when templates are derived using item.to_partial_path.

@n8
Copy link
Owner

n8 commented Mar 24, 2013

@DouweM just pulled in some pull requests, and now your work conflicts. Would you mind please updating? Sorry about the late attention to this.

@DouweM
Copy link
Author

DouweM commented Mar 24, 2013

Yup, I'll rebase tonight.

DouweM added 3 commits March 25, 2013 04:10
…ent read/write logging and use correct template when templates are derived using item.to_partial_path

@collection_data is an array containing the partial path for every item. Items in @collection need to have a  @collection_data counterpart at the same index.
@DouweM
Copy link
Author

DouweM commented Mar 25, 2013

Updated!

@n8
Copy link
Owner

n8 commented Mar 27, 2013

Is the custom key test failing for you?

1) MultiFetchFragments works for passing in a custom key
     Failure/Error: view.render(:partial => "views/customer", :collection => [ customer ], :cache => Proc.new{ |item| [item, 'key']}).should == "Hello: david\n"
       expected: "Hello: david\n"
            got: "Hello" (using ==)
       Diff:
       @@ -1,2 +1,2 @@
       -Hello: david
       +Hello

@DouweM
Copy link
Author

DouweM commented Mar 27, 2013

Edit: Disregard this.

It was failing for me before when it read .should == "Hello"; it works with the current .should == "Hello: david\n". I'm not sure where Hello comes from any way, seeing how spec/views/_customer.html.erb reads Hello: [name].

@DouweM
Copy link
Author

DouweM commented Apr 28, 2013

Any idea when you can review this?

@DouweM
Copy link
Author

DouweM commented Jun 24, 2013

@n8 Ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants