Skip to content

Conversation

@lochhh
Copy link
Member

@lochhh lochhh commented May 14, 2025

100s of warnings (UserWarning #573 and FutureWarning #593) were introduced in PR #476 and these obfuscate pytest's warnings summary, making it difficult to see if new changes are potentially introducing issues.

This PR filters out the aforementioned warnings.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4c31b3f) to head (a17feae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #592   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1615      1615           
=========================================
  Hits          1615      1615           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lochhh lochhh requested a review from a team May 14, 2025 18:46
@sfmig sfmig requested review from sfmig and removed request for a team May 15, 2025 10:42
@sfmig sfmig mentioned this pull request May 15, 2025
5 tasks
@sfmig
Copy link
Member

sfmig commented May 15, 2025

Heya, thanks for raising this.

Apologies, I missed fixing one of the two FutureWarnings in PR #476 - I have tackled that now in PR #594, which should make that filter warning unnecessary. With that fix we bring the warnings down to 36.

I agree that warnings clutter the CI logs and make it difficult to parse the information (we are also currently getting about ~100 lines of warnings re license syntax just at the beginning of running tox, see PR #549). But I am confused, these particular warnings you mention seem to be well contained in a reasonably sized summary section right (~16 lines)? Or are you referring to something else?

image

Re the Previous color_by key warning, I actually would like to keep an eye on it. It is coming from napari and I would like to see if an update fixes it, so I think keeping the warning visible would be helpful for that. But let me know thoughts.

@lochhh
Copy link
Member Author

lochhh commented May 15, 2025

Thanks @sfmig this is great! I can remove the FutureWarning filter in this PR, but I don't mean to close #573 with this PR; it's just to make the warnings summary easier to read when running pytest locally. This filter will of course be removed when we've tackled #573.

@sfmig
Copy link
Member

sfmig commented May 15, 2025

Ok sounds good, thanks for clarifying!
Yeah, I think just tracking the problem with issue #573 should be enough.

Will approve now 🚀

@sfmig sfmig force-pushed the napari-warnings branch from 01b0b5d to a17feae Compare May 15, 2025 13:02
@sonarqubecloud
Copy link

@sfmig sfmig added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 6fb8f91 May 15, 2025
30 of 35 checks passed
@lochhh lochhh deleted the napari-warnings branch May 19, 2025 16:03
niksirbi pushed a commit that referenced this pull request Jun 17, 2025
* Temporarily suppress napari warnings

* Remove FutureWarning filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants