-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step2 auto #4036
Step2 auto #4036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
민석님, 안녕하세요.
리뷰가 늦어서 죄송합니다.
이번 구현 정말 잘해주셨네요! 💯
넘어갈지 고민을 많이하다가 이번 단계에서 한번 더 보기로 했어요
코멘트 확인 후 재요청 부탁드립니다!
수고하셨습니다!
Lotto lastWeekLotto = new Lotto(Arrays.asList(1, 2, 3, 4, 5, 6)); | ||
|
||
Lottos lottos = new Lottos(List.of( | ||
new Lotto(Arrays.asList(1, 2, 3, 7, 8, 9)), // 3개 일치 → 5000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List.of
와 Arrays.asList
차이에 대해 알고 계시나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이참에 공부했습니다 감사합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
민석님 피드백 반영까지 잘 해주셨네요 👍
코멘트 남기면서 머지하겠습니다.
수고하셨습니다!
|
||
public double getProfitRate(int paidMoney) { | ||
// lottoCount * 1000 = 총 투자금 | ||
int lottoCount = paidMoney / 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로또 금액 1000원이 이곳저곳에서 사용되므로
상수화 시켜서 관리하면 좋지 않을까요?
private List<Integer> convertStringToList(String lastWeekLottoResult) { | ||
String[] split = lastWeekLottoResult.trim().split(","); | ||
List<Integer> integerList = new ArrayList<>(); | ||
for (String s : split) { | ||
integerList.add(Integer.parseInt(s.trim())); | ||
} | ||
return integerList; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lotto 애플리케이션 중심으로 봤을 때
해당 로직은 view 영역의 책임으로 이동시키는 게 나을 것 같다는 의견을 드리고 싶어요
InputView는 단순 콘솔 입력만을 처리하는 것이 아닌
비즈니스 로직을 처리하기 전 데이터를 전처리해주는 영역으로 생각해도 되지 않을까요?
민석님의 의견은 어떤가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은것같습니다. 의견감사합니다.
Step 2 기능 요구사항
Step 2 힌트