Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step2 auto #4036
Step2 auto #4036
Changes from all commits
99d1c9d
154300f
446943d
9121b85
0913eb8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금보면
List<Lotto>
와 차이 없이 래핑한 수준으로만 남아있는 객체네요Lottos
를 사용했을 때 어떤 이점을 가질 수 있었나요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로또 금액 1000원이 이곳저곳에서 사용되므로
상수화 시켜서 관리하면 좋지 않을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
외부에서 사용하지 않는다면 private으로 노출을 최소화시키는 게 좋겠네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lotto 애플리케이션 중심으로 봤을 때
해당 로직은 view 영역의 책임으로 이동시키는 게 나을 것 같다는 의견을 드리고 싶어요
InputView는 단순 콘솔 입력만을 처리하는 것이 아닌
비즈니스 로직을 처리하기 전 데이터를 전처리해주는 영역으로 생각해도 되지 않을까요?
민석님의 의견은 어떤가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은것같습니다. 의견감사합니다.