-
Notifications
You must be signed in to change notification settings - Fork 765
docs: Update migration note for plugin registry #6702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bentsherman
wants to merge
1
commit into
master
Choose a base branch
from
docs-migrate-25-10-plugin-registry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−18
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -148,8 +148,6 @@ The following environment variables control the configuration of the Nextflow ru | |||||
| : Default `organization` prefix when looking for a hosted repository (default: `nextflow-io`). | ||||||
|
|
||||||
| `NXF_PARAMS_FILE` | ||||||
| : :::{versionadded} 20.10.0 | ||||||
| ::: | ||||||
| : Defines the path location of the pipeline parameters file . | ||||||
|
|
||||||
| `NXF_PID_FILE` | ||||||
|
|
@@ -167,7 +165,7 @@ The following environment variables control the configuration of the Nextflow ru | |||||
| : The path where the plugin archives are loaded and stored (default: `$NXF_HOME/plugins`). | ||||||
|
|
||||||
| `NXF_PLUGINS_REGISTRY_URL` | ||||||
| : :::{versionadded} 25.08.0-edge | ||||||
| : :::{versionadded} 25.10.0 | ||||||
| ::: | ||||||
| : Specifies the URL of the plugin registry used to download and resolve plugins. This allows using custom or private plugin registries instead of the default public registry. | ||||||
|
|
||||||
|
|
@@ -182,34 +180,32 @@ The following environment variables control the configuration of the Nextflow ru | |||||
| : Defines the default behavior of `publishDir.failOnError` setting. See {ref}`publishDir<process-publishdir>` directive for more information. | ||||||
|
|
||||||
| `NXF_RETRY_POLICY_DELAY` | ||||||
| : :::{versionadded} 25.06.0-edge | ||||||
| : :::{versionadded} 25.10.0 | ||||||
| ::: | ||||||
| : Delay used for HTTP retryable operations (default: `350ms`). | ||||||
|
|
||||||
| `NXF_RETRY_POLICY_JITTER` | ||||||
| : :::{versionadded} 25.06.0-edge | ||||||
| : :::{versionadded} 25.10.0 | ||||||
| ::: | ||||||
| : Jitter value used for HTTP retryable operations (default: `0.25`). | ||||||
|
|
||||||
| `NXF_RETRY_POLICY_MAX_ATTEMPTS` | ||||||
| : :::{versionadded} 25.06.0-edge | ||||||
| : :::{versionadded} 25.10.0 | ||||||
| ::: | ||||||
| : Max number of attempts used for HTTP retryable operations (default: `5`). | ||||||
|
|
||||||
| `NXF_RETRY_POLICY_MAX_DELAY` | ||||||
| : :::{versionadded} 25.06.0-edge | ||||||
| : :::{versionadded} 25.10.0 | ||||||
| ::: | ||||||
| : Max delay used for HTTP retryable operations (default: `90s`). | ||||||
|
|
||||||
| `NXF_RETRY_POLICY_MULTIPLIER` | ||||||
| : :::{versionadded} 25.08.0-edge | ||||||
| : :::{versionadded} 25.10.0 | ||||||
| ::: | ||||||
| : Delay multiplier used for HTTP retryable operations (default: `2.0`). | ||||||
|
|
||||||
| `NXF_SCM_FILE` | ||||||
| : :::{versionadded} 20.10.0 | ||||||
| ::: | ||||||
| : Defines the path location of the SCM config file . | ||||||
| : Defines the path location of the SCM config file. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| `NXF_SINGULARITY_CACHEDIR` | ||||||
| : Directory where remote Singularity images are stored. When using a computing cluster it must be a shared folder accessible from all compute nodes. | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed?
nextflow/modules/nf-commons/src/main/nextflow/plugin/PluginsFacade.groovy
Lines 125 to 129 in 68d7544
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you said that 25.10 doesn't support the legacy index? Isn't that why we don't publish plugins requiring >=25.10 to the legacy index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got your point, however technically both NXF_PLUGINS_TEST_REPOSITORY and NXF_PLUGINS_REGISTRY_URL are still there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I am confused. Does 25.10 still support the legacy index or not?