Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom/shortenfastaids #5001

Closed
wants to merge 3 commits into from
Closed

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Feb 26, 2024

PR checklist

Closes #XXX

  • Added custom/shortenfastaids for Added a draft for fasta_ltrretriever_lai #4984
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@GallVp GallVp requested a review from a team as a code owner February 26, 2024 20:48
@GallVp GallVp requested review from LeuThrAsp and mahesh-panchal and removed request for a team February 26, 2024 20:48
@mahesh-panchal
Copy link
Member

Have you checked there are no other modules in nf-core modules that can provide this functionality?

@@ -0,0 +1,181 @@
#!/usr/bin/env python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get some LICENSE and authoring info on this script?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maxulysse

I have added the authoring and LICENSE info.

@GallVp
Copy link
Member Author

GallVp commented Feb 27, 2024

Google searches are leading me to custom scripts.

@mahesh-panchal
Copy link
Member

What about https://www.nextflow.io/docs/latest/operator.html#splitfasta. Can this operator replace this module in the subworkflow? For example, specifically using the record: [ id: true] or perhaps text or desc are relevant. Also this can work on files too using the map operator.

@GallVp GallVp mentioned this pull request May 9, 2024
17 tasks
@GallVp GallVp marked this pull request as draft May 9, 2024 07:52
@GallVp GallVp added the WIP Work in progress label May 9, 2024
@GallVp
Copy link
Member Author

GallVp commented Jun 5, 2024

Replaced with Groovy code, see #4984

@GallVp GallVp closed this Jun 5, 2024
@GallVp GallVp deleted the shortenfastaids branch June 7, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants