Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix falco sample names #7394

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MartinGrignard
Copy link

Hi 👋

This PR modifies the definition of the falco module so that the reported sample names are affected by the value of the prefix variable instead of the actual input file name.
To achieve this, it simply uses the same strategy as many other modules: Symlinks are now created to provide input files named after the desired prefix.
This makes it easier to include falco output in MultiQC reports.

In the meantime, I also updated the value of falco form 1.2.1 to 1.2.5.

Martin Grignard and others added 3 commits January 30, 2025 09:53
Symlinks are now created as in other modules to make sure that the reported sample names are affected by the value of `prefix`. This makes it easier to use `falco` in `MultiQC` reports.
@SPPearce
Copy link
Contributor

You'll need to regenerate the test snapshots (nf-core modules test falco --update) and update the environment.yml to change the conda module version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants