Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MALT/BUILD: Start adding a2tax support #7409

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 31, 2025

Currently not working due to not being able to retrieve the old abin file needed for the second test

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jfy133 jfy133 changed the title Start adding a2tax support MALT/BUILD: Start adding a2tax support Jan 31, 2025
@jfy133 jfy133 marked this pull request as ready for review February 4, 2025 10:25
@jfy133 jfy133 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into nf-core:master with commit 090e0b6 Feb 5, 2025
28 checks passed
@jfy133 jfy133 deleted the update-malt branch February 5, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants