-
Notifications
You must be signed in to change notification settings - Fork 116
Remove unused service annotations #3362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sjberman
merged 3 commits into
change/control-data-plane-split
from
chore/remove-service-annotations
May 14, 2025
Merged
Remove unused service annotations #3362
sjberman
merged 3 commits into
change/control-data-plane-split
from
chore/remove-service-annotations
May 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjberman
approved these changes
May 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3362 +/- ##
===================================================================
+ Coverage 86.73% 86.75% +0.01%
===================================================================
Files 129 129
Lines 14862 14862
Branches 62 62
===================================================================
+ Hits 12891 12893 +2
+ Misses 1822 1820 -2
Partials 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
salonichf5
approved these changes
May 7, 2025
10 tasks
sjberman
pushed a commit
that referenced
this pull request
May 14, 2025
* Remove unused service annotations * Remove files for aws-nlb that rely on service annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Pull requests for routine tasks
documentation
Improvements or additions to documentation
helm-chart
Relates to helm chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused service annotations. This field on NginxProxy and set through Helm is never used, instead service annotations are set through annotations on the Gateway object.
Will update docs installation through manifests to give more information when installing with aws-nlb.