Skip to content

Remove unused service annotations #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented May 6, 2025

Remove unused service annotations. This field on NginxProxy and set through Helm is never used, instead service annotations are set through annotations on the Gateway object.

Will update docs installation through manifests to give more information when installing with aws-nlb.

@bjee19 bjee19 requested a review from a team as a code owner May 6, 2025 19:04
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks helm-chart Relates to helm chart labels May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (5abe667) to head (119197e).
Report is 1 commits behind head on change/control-data-plane-split.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #3362      +/-   ##
===================================================================
+ Coverage                            86.73%   86.75%   +0.01%     
===================================================================
  Files                                  129      129              
  Lines                                14862    14862              
  Branches                                62       62              
===================================================================
+ Hits                                 12891    12893       +2     
+ Misses                                1822     1820       -2     
  Partials                               149      149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman merged commit f659def into change/control-data-plane-split May 14, 2025
44 checks passed
@sjberman sjberman deleted the chore/remove-service-annotations branch May 14, 2025 16:38
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric May 14, 2025
sjberman pushed a commit that referenced this pull request May 14, 2025
* Remove unused service annotations

* Remove files for aws-nlb that rely on service annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants