Add ReadDigitalWaveforms to NiDAQmxService #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 16, 2025 13:32
- Added ReadAnalogWaveforms method stub to NiDAQmxService for reading analog waveforms. - Updated metadata validation to include CustomCodeNoLibrary. - Introduced new waveform attributes and functions in metadata. - Enhanced CMake configuration for new protobuf files. - Improved CONTRIBUTING.md with Ninja build instructions.
… users/mprosser/task-3424630-read-digital-waveforms
… is off by 5ish months)
added 14 commits
October 27, 2025 14:01
… users/mprosser/task-3424630-read-digital-waveforms
… users/mprosser/task-3424630-read-digital-waveforms
…424630-read-digital-waveforms
mikeprosserni
requested review from
astarche,
maxxboehme and
reckenro
as code owners
…424630-read-digital-waveforms
bkeryan
requested changes
Oct 30, 2025
bkeryan
approved these changes
Oct 30, 2025
reckenro
approved these changes
Oct 30, 2025
mikeprosserni
deleted the
users/mprosser/task-3424630-read-digital-waveforms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
-Add ReadDigitalWaveforms method to the NiDAQmxService
Why should this Pull Request be merged?
AB#3424630
What testing has been done?
I added four tests for ReadDigitalWaveforms:
I also update the proof of concept in nidaqmx-python to use this new ReadDigitalWaveforms RPC, and now the grpc versions of the related tests are passing:
(This demonstrates that all the multi-channel/multi-line/port handling is working as expected.)