-
Notifications
You must be signed in to change notification settings - Fork 65
Add ReadDigitalWaveforms to NiDAQmxService #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mikeprosserni
merged 47 commits into
main
from
users/mprosser/task-3424630-read-digital-waveforms
Oct 30, 2025
Merged
Changes from 44 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
5e53c36
Enhance NIDAQmx API with waveform support and additional metadata
fff7769
fix lint
01ea5e9
fix validate_examples
1270fd7
ReadAnalogWaveforms implementation (untested, but compiles)
836c408
add tests
b9cf67a
Add support for creating two AI voltage channels in tests
12ca5e5
cleanup
8e5eb77
cleanup CMakeLists.txt
7b50a84
attempt fix for ubuntu build
3d29cbc
more verbose build output
9b26670
Try some different build settings
d117ec2
add quotes to fix cmake flags
23a6e98
add sampsPerChanRead to ReadAnalogWaveforms response
1577116
revert changes in build_cmake.yml and do -fno-var-tracking-assignment…
c03a50d
use GCC push_options
4c36ac8
use -fno-var-tracking-assignments globally for gcc
e7055d1
fix timing conversion
5aa982d
add ReadDigitalWaveforms RPC with stub implementation
a765c94
implementation and tests for single channel
26c1608
test multi channel and multi line
0b45f4b
add copilot instructions for how to build with ninja, and do some cle…
ec3e076
fix data layout
ae53b1c
brad's feedback
9c0c333
copy protobuf types protos to heirarchical location
85d899b
Merge branch 'users/mprosser/task-3424627-read-analog-waveforms' into…
c56bd62
fix merge and templatize the SetWfmAttrCallback
95f15c2
copilot-build.ps1
e3109e7
handle epoch difference (note - SecondsFrom0001EpochTo1904Epoch value…
7b90ab4
convert_dot_net_daqmx_ticks_to_btf_precision_timestamp
9f77232
fixes and cleanup
4f7cf86
cleanup and more test cases
2962d82
PrecisionTimestampConverterLiteralTests
50767bb
Merge branch 'users/mprosser/task-3424627-read-analog-waveforms' into…
4a87aa8
fix merge
897e6f3
remove copilot instructions (will be added in separate PR)
ba59257
use correct logic for NI-BTF
cf85e37
test cleanup
5df95b9
Merge branch 'users/mprosser/task-3424627-read-analog-waveforms' into…
3b6681f
fillMode: 1 = GROUP_BY_SCAN_NUMBER (interleaved)
664f03a
Merge remote-tracking branch 'origin/main' into users/mprosser/task-3…
1579f84
cleanup merge
c33446b
cleanup
30355e1
use waveform->mutable_y_data();
ca6e216
test cleanup
cfef232
Merge remote-tracking branch 'origin/main' into users/mprosser/task-3…
b40de09
Brad's feedback
0321106
cleanup
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.