Preliminary support for the base component on Windows. #44
Conversation
| if(NOT WIN32) # TODO(#36): Enable on Windows and/or make subproject inclusion generally optional | ||
|
|
||
| therock_cmake_subproject_declare(rocprofiler-register | ||
| EXTERNAL_SOURCE_DIR "rocprofiler-register" |
There was a problem hiding this comment.
Argh, and this also won't work due to a dep here:
Lines 5 to 13 in b3307ed
I had this "working" on Friday with my build directory, but now seeing issues with a fresh build.
There was a problem hiding this comment.
Yeah... That's a non optional dep to a few things
There was a problem hiding this comment.
Okay, I'm going in circles here. This is actually fine, as long as I have 'core' also excluded, which I do:
if(NOT WIN32)
add_subdirectory(compiler)
add_subdirectory(core)
There was a problem hiding this comment.
Picking this back up with a fresh set of eyes and some hacks to get a CI runner past the symlink issues.
The excludes that I have here are sufficient to build, but they aren't a comfortable solution. I'd like to proceed with this approach for now then see about making rocprofiler-register (and other projects) compile successfully but no-op in some/all of its functionality as needed.
ScottTodd
force-pushed
the
windows-bootstrap
branch
from
90580f8 to
51e938a
Compare
Progress on #36.
Together with some other pending PRs, this gets me enough to
Not much is actually getting built, since this disables nearly all projects on Windows, but this is enough to start running CI builds and working on components incrementally.