-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
url: improve canParse() performance for non-onebyte strings #58023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
anonrig:yagiz/improve-perf-url-canparse
Apr 27, 2025
Merged
url: improve canParse() performance for non-onebyte strings #58023
nodejs-github-bot
merged 1 commit into
nodejs:main
from
anonrig:yagiz/improve-perf-url-canparse
Apr 27, 2025
+62
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
d9dca31
to
cdd187c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58023 +/- ##
==========================================
- Coverage 90.28% 90.26% -0.02%
==========================================
Files 630 630
Lines 186158 186347 +189
Branches 36484 36499 +15
==========================================
+ Hits 168067 168212 +145
- Misses 10974 11007 +33
- Partials 7117 7128 +11
🚀 New features to boost your workflow:
|
lemire
approved these changes
Apr 25, 2025
gurgunday
approved these changes
Apr 26, 2025
H4ad
approved these changes
Apr 26, 2025
jasnell
approved these changes
Apr 26, 2025
cdd187c
to
ffba018
Compare
ffba018
to
375bc78
Compare
H4ad
approved these changes
Apr 27, 2025
Landed in e0cf8ae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 Fast API now supports v8::Localv8::Value as a parameter type and we can access isolate and context through the fast api. Let's update our implementation to reflect the new limitations.
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1702
cc @nodejs/performance