Skip to content

test(decompress): wait for highWaterMark via readable instead of setImmediate loop - #5841

Merged
mcollina merged 1 commit into
nodejs:mainfrom
kjsik11:test/decompress-backpressure-flake
Sep 18, 2026
Merged

mcollina merged 1 commit into
nodejs:mainfrom
kjsik11:test/decompress-backpressure-flake

Conversation

@kjsik11

@kjsik11 kjsik11 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

This relates to...

Rationale

The test waits for the body to reach highWaterMark with a loop of 100 setImmediate ticks, which is unreliable when the threadpool is busy.

Changes

Wait for readableHighWaterMark to be reached via the readable event instead of a setImmediate loop.

Tests

Assisted-by: Claude Code

Status

@codecov-commenter

codecov-commenter commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (bfea020) to head (c0f3dc8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5841   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files         110      110           
  Lines       39773    39773           
=======================================
+ Hits        37200    37201    +1     
+ Misses       2573     2572    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina merged commit 4fb32a0 into nodejs:main Sep 18, 2026
34 of 37 checks passed
@kjsik11
kjsik11 deleted the test/decompress-backpressure-flake branch September 21, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants