Skip to content

test(decompress): wait for highWaterMark via readable instead of setImmediate loop #5841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 1 commit into from
Sep 18, 2026
+10 −7
Merged

test(decompress): wait for highWaterMark via readable instead of setImmediate loop #5841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions test/interceptors/decompress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1177,15 +1177,18 @@ test('decompress backpressure bounds an initially unread request body', { timeou
highWaterMark: 32 * 1024
})

if (body.readableLength === 0) {
await once(body, 'readable')
}
await responseFinished
for (let i = 0; i < 100 && body.readableLength < body.readableHighWaterMark; i++) {
await immediate()
}
await new Promise(resolve => {
const onReadable = () => {
if (body.readableLength >= body.readableHighWaterMark) {
body.off('readable', onReadable)
resolve()
}
}
body.on('readable', onReadable)
onReadable()
})

assert(body.readableLength >= body.readableHighWaterMark)
assert(
body.readableLength <= body.readableHighWaterMark + 16 * 1024,
`buffered ${body.readableLength} bytes for HWM ${body.readableHighWaterMark}`
Expand Down
Loading