[W5.7][F10-2]Lim Fong Yuan #454
Conversation
…wline and added indentation for Command.getMessageUsage().
…s that take in no parameters.
|
You are failing the unit tests. |
test/expected.txt
Outdated
| @@ -29,10 +29,10 @@ | |||
| || Example: viewall 1 | |||
| || help: Shows program usage instructions. | |||
| || Parameters: none | |||
| || Example: help | |||
| || Example: help | |||
There was a problem hiding this comment.
As the script uses a 'diff', whitespace might be causing the CI to fail.
There was a problem hiding this comment.
That's strange, because both my expected and my actual output do not have any whitespace at the end of line 32.
I've made a clean clone of this branch to my com and ran runtests.bat, and it reports no difference as well.
I did change the formatting of the text files while I was working on this while I was troubleshooting why the identical-looking files are being reported as different. Maybe that's the issue instead?
| + "\n" + ViewAllCommand.MESSAGE_USAGE | ||
| + "\n" + HelpCommand.MESSAGE_USAGE | ||
| + "\n" + ExitCommand.MESSAGE_USAGE | ||
| + DeleteCommand.MESSAGE_USAGE |
There was a problem hiding this comment.
Why remove the new line? If you have added the "\n" in another commit, you should squash the commit to be together with this. It is unclear why you are removing new lines.
|
Good job, but maybe could add more JUnit and IO test cases :) |
| * @return the MESSAGE_USAGE for a command. | ||
| */ | ||
| protected static String getMessageUsage( | ||
| String commandWord, |
There was a problem hiding this comment.
Indentation for wrapped lines should be 8 spaces
|
Hi Fong Yuan, Commit titles should be less than 72 characters and have no full stops, which is why some of your commits got wrapped to the next line. |
Extract a Command.getMessageUsage() method and format the help command.