Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W5.7][F10-2]Lim Fong Yuan #454

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[W5.7][F10-2]Lim Fong Yuan #454

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4951d26
Add an isAnyNullTest() to test the Utils.isAnyNull() method.
OrangeJuice7 Sep 7, 2018
bb32fd1
Format the clear command in the help display like the rest of the com…
OrangeJuice7 Sep 13, 2018
bf2d7f2
Update test/expected.txt to reflect the change in output.
OrangeJuice7 Sep 13, 2018
472c06d
Add getMessageUsage() method to Command and convert AddCommand as a s…
OrangeJuice7 Sep 13, 2018
9a7b50b
Update the rest of the commands to use getMessageUsage().
OrangeJuice7 Sep 13, 2018
8bfa4cb
Remove the extra newline characters in the help command.
OrangeJuice7 Sep 13, 2018
f58b101
Re-add the newline characters in the help command, and removed the ne…
OrangeJuice7 Sep 13, 2018
71cf24f
Overload Command.getMessageUsage() to simplify declaration of command…
OrangeJuice7 Sep 13, 2018
0daf664
Update test/expected.txt
OrangeJuice7 Sep 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/seedu/addressbook/commands/HelpCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ public class HelpCommand extends Command {
public CommandResult execute() {
return new CommandResult(
AddCommand.MESSAGE_USAGE
+ "\n" + DeleteCommand.MESSAGE_USAGE
+ "\n" + ClearCommand.MESSAGE_USAGE
+ "\n" + FindCommand.MESSAGE_USAGE
+ "\n" + ListCommand.MESSAGE_USAGE
+ "\n" + ViewCommand.MESSAGE_USAGE
+ "\n" + ViewAllCommand.MESSAGE_USAGE
+ "\n" + HelpCommand.MESSAGE_USAGE
+ "\n" + ExitCommand.MESSAGE_USAGE
+ DeleteCommand.MESSAGE_USAGE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the new line? If you have added the "\n" in another commit, you should squash the commit to be together with this. It is unclear why you are removing new lines.

+ ClearCommand.MESSAGE_USAGE
+ FindCommand.MESSAGE_USAGE
+ ListCommand.MESSAGE_USAGE
+ ViewCommand.MESSAGE_USAGE
+ ViewAllCommand.MESSAGE_USAGE
+ HelpCommand.MESSAGE_USAGE
+ ExitCommand.MESSAGE_USAGE
);
}
}