feat: Allow to expand nodes until certain condition is met #3166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostbuster91
commented
Jul 20, 2025
| ---@param mode string | ||
| ---@param node Node | ||
| ---@param edit_opts NodeEditOpts? | ||
| local function edit(mode, node, edit_opts) |
There was a problem hiding this comment.
thought: just moved this function higher so that I can refer to it from toggle_descend_until
ghostbuster91
commented
Jul 20, 2025
| Api.tree.expand_all = wrap_node(actions.tree.modifiers.expand.all) | ||
|
|
||
| Api.tree.toggle_descend_until = wrap_node(function(node, descend_until) |
There was a problem hiding this comment.
note: this is actually what I would like to achieve in the end. The fixededit part is wrong as nodes are not getting collapsed after hitting enter for the second time. Can you advise?
question: how should the end user api look like?
|
Thanks for getting back to this one @ghostbuster91 My time is limited, however I will get to reviewing next weekend. FYI the nightly CI failure has been resolved on master: #3167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2789
It took me a while but here I am :) I decided to create a fresh one as it was easier then resolving conflicts on the old one.
For now bare minimum of the changes that makes it work. Once we agree how the api will look like I will add docs following what we did in #2790