Skip to content

feat(#2789): add optional function expand_until to api.tree.expand_all and api.node.expand #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Aug 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c1948cb
feat: Allow to expand nodes until certain condition is met
ghostbuster91 Jul 20, 2025
641f125
Fix warnings
ghostbuster91 Jul 20, 2025
114fde0
Merge branch 'master' into expand-until-2
alex-courtis Jul 27, 2025
72404b9
Restore original position of edit function
ghostbuster91 Aug 2, 2025
06575bc
Rename field to match the api method name
ghostbuster91 Aug 2, 2025
8936460
Rename ApiTreeExpandAllOpts to ApiTreeExpandOpts
ghostbuster91 Aug 2, 2025
e3c3105
Merge branch 'master' into expand-until-2
ghostbuster91 Aug 2, 2025
71271e3
Remove toggle_descend_until
ghostbuster91 Aug 2, 2025
03e3a15
Remove redundant empty line
ghostbuster91 Aug 2, 2025
4ab16dd
Update :help for changed methods
ghostbuster91 Aug 2, 2025
3dac0be
Fix partial expansion of grouped nodes
ghostbuster91 Aug 2, 2025
160ae4f
Fix lint error
ghostbuster91 Aug 2, 2025
37b3516
Fix linting error
ghostbuster91 Aug 2, 2025
587068c
Merge branch 'master' into expand-until-2
ghostbuster91 Aug 10, 2025
eabd08c
Fix incorrect open/close indicator state
ghostbuster91 Aug 10, 2025
669a79f
Update docs
ghostbuster91 Aug 10, 2025
8425ef0
Rename descend_until option to expand_until
ghostbuster91 Aug 10, 2025
c4777ab
Always check directory expansion limit
ghostbuster91 Aug 10, 2025
cc25680
Fix linter errors
ghostbuster91 Aug 10, 2025
ba2d11f
Ignore unused param warning
ghostbuster91 Aug 10, 2025
8ecfcd0
Apply suggestions from code review
alex-courtis Aug 11, 2025
8c42c02
simplify MAX_FOLDER_DISCOVERY warning
alex-courtis Aug 11, 2025
3c666c4
fix bad comment whitespace
alex-courtis Aug 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions doc/nvim-tree-lua.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1841,11 +1841,17 @@ tree.collapse_all({opts}) *nvim-tree-api.tree.collapse_all()*
Options: ~
• {keep_buffers} (boolean) do not collapse nodes with open buffers.

tree.expand_all({node}) *nvim-tree-api.tree.expand_all()*
tree.expand_all({node}, {opts}) *nvim-tree-api.tree.expand_all()*
Recursively expand all nodes under the tree root or specified folder.

Parameters: ~
• {node} (Node|nil) folder
• {opts} (ApiTreeExpandOpts) optional parameters

Options: ~
• {expand_until} ((fun(expansion_count: integer, node: Node?): boolean)?)
Return true if {node} should be expanded.
{expansion_count} is the total number of folders expanded.

*nvim-tree-api.tree.toggle_enable_filters()*
tree.toggle_enable_filters()
Expand Down Expand Up @@ -2279,12 +2285,18 @@ node.buffer.wipe({node}, {opts}) *nvim-tree-api.node.buffer.wipe()*
Options: ~
• {force} (boolean) wipe even if buffer is modified, default false

node.expand({node}) *nvim-tree-api.node.expand()*
node.expand({node}, {opts}) *nvim-tree-api.node.expand()*
Recursively expand all nodes under a directory or a file's parent
directory.

Parameters: ~
• {node} (Node|nil) file or folder
• {opts} (ApiTreeExpandOpts) optional parameters

Options: ~
• {expand_until} ((fun(expansion_count: integer, node: Node?): boolean)?)
Return true if {node} should be expanded.
{expansion_count} is the total number of folders expanded.

node.collapse({node}, {opts}) *nvim-tree-api.node.collapse()*
Collapse the tree under a directory or a file's parent directory.
Expand Down
95 changes: 75 additions & 20 deletions lua/nvim-tree/actions/tree/modifiers/expand.lua
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,66 @@ local function expand(node)
end
end

---@param expansion_count integer
---@param should_descend fun(expansion_count: integer, node: Node): boolean
---@return fun(expansion_count: integer, node: Node): boolean
local function limit_folder_discovery(should_descend)
return function(expansion_count, node)
local should_halt = expansion_count >= M.MAX_FOLDER_DISCOVERY
if should_halt then
notify.warn("expansion iteration was halted after " .. M.MAX_FOLDER_DISCOVERY .. " discovered folders")
return false
end

return should_descend(expansion_count, node)
end
end

---@param _ integer expansion_count
---@param node Node
---@return boolean
local function should_expand(expansion_count, node)
local function descend_until_empty(_, node)

local dir = node:as(DirectoryNode)
if not dir then
return false
end
local should_halt = expansion_count >= M.MAX_FOLDER_DISCOVERY

local should_exclude = M.EXCLUDE[dir.name]
return not should_halt and not dir.open and not should_exclude
return not should_exclude
end

local function gen_iterator()
---@param expansion_count integer
---@param node Node
---@param should_descend fun(expansion_count: integer, node: Node): boolean
---@return boolean
local function should_expand(expansion_count, node, should_descend)
local dir = node:as(DirectoryNode)
if not dir then
return false
end

if not dir.open and should_descend(expansion_count, node) then
if #node.nodes == 0 then
core.get_explorer():expand(dir) -- populate node.group_next
end

if dir.group_next then
local expand_next = should_expand(expansion_count, dir.group_next, should_descend)
if expand_next then
dir.open = true
end
return expand_next
else
return true
end
end
return false
end


---@param should_descend fun(expansion_count: integer, node: Node): boolean
---@return fun(node): any
local function gen_iterator(should_descend)
local expansion_count = 0

return function(parent)
Expand All @@ -52,7 +98,7 @@ local function gen_iterator()
Iterator.builder(parent.nodes)
:hidden()
:applier(function(node)
if should_expand(expansion_count, node) then
if should_expand(expansion_count, node, should_descend) then
expansion_count = expansion_count + 1
node = node:as(DirectoryNode)
if node then
Expand All @@ -61,25 +107,32 @@ local function gen_iterator()
end
end)
:recursor(function(node)
return expansion_count < M.MAX_FOLDER_DISCOVERY and (node.group_next and { node.group_next } or (node.open and node.nodes))
if not should_descend(expansion_count, node) then
return nil
end

if node.group_next then
return { node.group_next }
end

if node.open and node.nodes then
return node.nodes
end

return nil
end)
:iterate()

if expansion_count >= M.MAX_FOLDER_DISCOVERY then
return true
end
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max folder discovery test above does not appear to be necessary as limit_folder_discovery does the job.

Commenting this out results in the correct number of folders being expanded, just no message.

Having the same test twice in two locations is fragile and unclear.

Proposal: limit_folder_discovery prints the warning and gen_iterator's function returns nothing.


---@param node Node?
local function expand_node(node)
---@param expand_opts ApiTreeExpandOpts?
local function expand_node(node, expand_opts)
if not node then
return
end

if gen_iterator()(node) then
notify.warn("expansion iteration was halted after " .. M.MAX_FOLDER_DISCOVERY .. " discovered folders")
end
local descend_until = limit_folder_discovery((expand_opts and expand_opts.expand_until) or descend_until_empty)
gen_iterator(descend_until)(node)

local explorer = core.get_explorer()
if explorer then
Expand All @@ -89,18 +142,20 @@ end

---Expand the directory node or the root
---@param node Node
function M.all(node)
expand_node(node and node:as(DirectoryNode) or core.get_explorer())
---@param expand_opts ApiTreeExpandOpts?
function M.all(node, expand_opts)
expand_node(node and node:as(DirectoryNode) or core.get_explorer(), expand_opts)
end

---Expand the directory node or parent node
---@param node Node
function M.node(node)
---@param expand_opts ApiTreeExpandOpts?
function M.node(node, expand_opts)
if not node then
return
end

expand_node(node:is(FileNode) and node.parent or node:as(DirectoryNode))
expand_node(node:is(FileNode) and node.parent or node:as(DirectoryNode), expand_opts)
end

function M.setup(opts)
Expand Down
4 changes: 4 additions & 0 deletions lua/nvim-tree/api.lua
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,10 @@ Api.tree.search_node = wrap(actions.finders.search_node.fn)
---@field keep_buffers boolean|nil default false

Api.tree.collapse_all = wrap(actions.tree.modifiers.collapse.all)

---@class ApiTreeExpandOpts
---@field expand_until (fun(expansion_count: integer, node: Node): boolean)|nil

Api.tree.expand_all = wrap_node(actions.tree.modifiers.expand.all)
Api.tree.toggle_enable_filters = wrap_explorer_member("filters", "toggle")
Api.tree.toggle_gitignore_filter = wrap_explorer_member_args("filters", "toggle", "git_ignored")
Expand Down
Loading