Simulation interfaces gem #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Pełka <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR implements the SimulationEntitiesManager as part of the RFC for simulation enhancements. The changes include the addition of a .clang-format file to enforce consistent C++ style conventions tailored for the gem.
Files not reviewed (18)
- Gems/SimulationInterfaces/Assets/SampleAsset/TestSimulationEntity.prefab: Language not supported
- Gems/SimulationInterfaces/CMakeLists.txt: Language not supported
- Gems/SimulationInterfaces/Code/CMakeLists.txt: Language not supported
- Gems/SimulationInterfaces/Code/Include/SimulationInterfaces/SimulationInterfacesBus.h: Language not supported
- Gems/SimulationInterfaces/Code/Include/SimulationInterfaces/SimulationInterfacesTypeIds.h: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Android/PAL_android.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Android/simulationinterfaces_api_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Android/simulationinterfaces_private_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Android/simulationinterfaces_shared_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Linux/PAL_linux.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Linux/simulationinterfaces_api_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Linux/simulationinterfaces_editor_api_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Linux/simulationinterfaces_private_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Linux/simulationinterfaces_shared_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Mac/PAL_mac.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Mac/simulationinterfaces_api_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Mac/simulationinterfaces_editor_api_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Mac/simulationinterfaces_private_files.cmake: Language not supported
Signed-off-by: Michał Pełka <[email protected]>
michalpelka
force-pushed
the
rb/simulation_interfaces_gem
branch
from
9d58a9b to
25b280c
Compare
zakmat
reviewed
Apr 1, 2025
Gems/SimulationInterfaces/Code/Include/SimulationInterfaces/SimulationInterfacesBus.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Michał Pełka <[email protected]>
Signed-off-by: Michał Pełka <[email protected]>
zakmat
suggested changes
Apr 1, 2025
Gems/SimulationInterfaces/Code/Include/SimulationInterfaces/SimulationInterfacesBus.h
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Source/Tools/SimulationEntitiesMangerEditor.h
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Include/SimulationInterfaces/SimulationInterfacesBus.h
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Source/Clients/ConsoleCommands.icl
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Source/Clients/SimulationEntitiesManager.cpp
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Source/Clients/SimulationEntitiesManager.cpp
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Source/Clients/SimulationEntitiesManager.cpp
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Source/Clients/SimulationEntitiesManager.cpp
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Source/Clients/SimulationEntitiesManager.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Michał Pełka <[email protected]>
Signed-off-by: Michał Pełka <[email protected]>
Gems/SimulationInterfaces/Code/Source/Clients/SimulationEntitiesManager.cpp
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Tests/Tools/SimulationInterfaceTests.cpp
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Tests/Tools/SimulationInterfaceTests.cpp
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Tests/Tools/SimulationInterfaceTests.cpp
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Tests/Tools/SimulationInterfaceTests.cpp
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Tests/Tools/SimulationIterfaceAppTest.cpp
Outdated
Show resolved
Hide resolved
Gems/SimulationInterfaces/Code/Tests/Tools/SimulationIterfaceAppTest.cpp
Outdated
Show resolved
Hide resolved
patrykantosz
reviewed
Apr 2, 2025
Gems/SimulationInterfaces/Code/Source/Clients/SimulationEntitiesManager.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Michał Pełka <[email protected]>
|
Ok @zakmat @norbertprokopiuk @norbertprokopiuk thank for review, agreed with all your recommendations! |
michalpelka
requested review from
Copilot,
norbertprokopiuk,
patrykantosz and
zakmat
There was a problem hiding this comment.
Pull Request Overview
This PR implements the SimulationEntitiesManager as part of the Simulation Interfaces gem per the RFC, and introduces formatting standards via a new .clang-format configuration file.
- Introduces a new .clang-format file to enforce consistent code formatting.
- Sets various C++ formatting options (e.g., brace wrapping options, alignment settings, and spacing rules) to standardize the codebase.
Files not reviewed (18)
- Gems/SimulationInterfaces/Assets/SampleAsset/TestSimulationEntity.prefab: Language not supported
- Gems/SimulationInterfaces/CMakeLists.txt: Language not supported
- Gems/SimulationInterfaces/Code/CMakeLists.txt: Language not supported
- Gems/SimulationInterfaces/Code/Include/SimulationInterfaces/SimulationEntityManagerRequestBus.h: Language not supported
- Gems/SimulationInterfaces/Code/Include/SimulationInterfaces/SimulationInterfacesTypeIds.h: Language not supported
- Gems/SimulationInterfaces/Code/Include/SimulationInterfaces/SimulationMangerRequestBus.h: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Android/PAL_android.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Android/simulationinterfaces_api_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Android/simulationinterfaces_private_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Android/simulationinterfaces_shared_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Linux/PAL_linux.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Linux/simulationinterfaces_api_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Linux/simulationinterfaces_editor_api_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Linux/simulationinterfaces_private_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Linux/simulationinterfaces_shared_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Mac/PAL_mac.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Mac/simulationinterfaces_api_files.cmake: Language not supported
- Gems/SimulationInterfaces/Code/Platform/Mac/simulationinterfaces_editor_api_files.cmake: Language not supported
|
@copilot, your review is useless. |
norbertprokopiuk
approved these changes
Apr 2, 2025
michalpelka
merged commit 9e440b2
into
o3de:feature/simulation_interfaces
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is part of implementation of RFC o3de/sig-simulation#95. It implements SimulationEntitiesManager.
How was this PR tested?
Included test App, some unit test.