omero.gateway: deprecate BlitzObjectWrapper.getExternalInfo() #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlitzObjectWrapper.getDetails().getExternalInfo() should provide the same lazy-loading functionality and return a wrapped ExternalInfo
knabar
approved these changes
Oct 2, 2025
will-moore
approved these changes
Nov 26, 2025
Member
will-moore
left a comment
will-moore
left a comment
There was a problem hiding this comment.
OK - It's consistent with other getDetails() methods.
Code changes look good.
Member
|
Added a note to https://github.com/ome/omero-web/pull/613/files to drop usage of this method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #481 and the latest discussion
BlitzObjectWrapper.getDetails().getExternalInfo() should provide the same lazy-loading functionality and return a wrapped ExternalInfo
Consumers who might have adopted the OMERO.py gateway API introduced in #453 should update their code to use the existing
object.getDetails().getExternalInfo()API which is separately being fixed with #482.This approach is consistent with similar metadata like
getDetails().getGroup(),getDetails().getOwner()orgetDetails().getPermissions(). UnlikeBlitzObjectWrapper.getExternalInfo(), this API will return a wrappedExternalInfoobject allowing to use the convenience methods of the gateway e.g.object.getDetails().getExternalInfo().getLsid()