-
-
Notifications
You must be signed in to change notification settings - Fork 62
Dict override syntax to allow standard form: --cfg.dict.key val #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for contributing! The fix in _typehints.py file looks good.
Please:
- Change the pull request title to something that summarizes what is being fixed.
- In the changelog only a single entry with a description similar to the pull request title and a link only to the pull request, not the issue. Also it should be in the already existing
Fixedsubsection. - Add a unit test, that should fail without the
_typehints.pyfix.
|
Addressed the comments cc @mauvilsa |
mauvilsa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is not the same case as #823. Please fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 7234 7237 +3
=========================================
+ Hits 7234 7237 +3 ☔ View full report in Codecov by Sentry. |
What does this PR do?
Fixes #823
To summarize, if the config class has a dict member, then the override was of the form
--cfg.dict '{"key": val}'This PR allows passing in
--cfg.dict.key valThe existing syntax is still valid.
Before submitting