Skip to content

Dict override syntax to allow standard form: --cfg.dict.key val #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mauvilsa merged 6 commits into from
Dec 25, 2025
Merged

Dict override syntax to allow standard form: --cfg.dict.key val #824

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
17f3cf0
proposed fix
ganatraad Dec 14, 2025
81c239a
check key type
ganatraad Dec 14, 2025
fccc664
changelog
ganatraad Dec 14, 2025
5c8f834
from comments
ganatraad Dec 23, 2025
76ce85d
fixed test
ganatraad Dec 24, 2025
27edf8e
Apply suggestion from @mauvilsa
mauvilsa Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ paths are considered internals and can change in minor and patch releases.
v4.45.0 (unreleased)
--------------------

Fixed
^^^^^
- Overrides for nested keys in dict. Issue (`#823
<https://github.com/omni-us/jsonargparse/issues/823>`__).
- ``Issue-823`` (`#824
<https://github.com/omni-us/jsonargparse/pull/824>`__).

Added
^^^^^
- Signature methods now when given ``sub_configs=True``, list of paths types can
Expand Down
6 changes: 5 additions & 1 deletion jsonargparse/_typehints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,11 @@ def adapt_typehints(
elif typehint_origin in mapping_origin_types:
if isinstance(val, NestedArg):
if isinstance(prev_val, dict):
val = {**prev_val, val.key: val.val}
if isinstance(val.key, str) and "." in val.key:
key_prefix, key_suffix = val.key.split(".", 1)
val = {**prev_val, key_prefix: {key_suffix: val.val}}
else:
val = {**prev_val, val.key: val.val}
else:
val = {val.key: val.val}
elif isinstance(val, MappingProxyType):
Expand Down