fix: implement requirement 1.6.2 #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage 85.68% 85.69%
=======================================
Files 20 20
Lines 1432 1433 +1
=======================================
+ Hits 1227 1228 +1
Misses 184 184
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bduffany
force-pushed
the
shutdown-fix
branch
5 times, most recently
from
fa3fc6f to
7a783dd
Compare
sahidvelji
reviewed
Jul 4, 2025
|
I'll take a look at this next week. |
|
I hope the specification enhancement here makes the way forward here less ambiguous. |
beeme1mr
approved these changes
Jul 29, 2025
sahidvelji
reviewed
Jul 29, 2025
toddbaert
approved these changes
Aug 14, 2025
bduffany
changed the title
bduffany
changed the title
bduffany
changed the title
The spec says that shutdown must shut down active providers, but the current logic shuts down inactive providers. This change fixes that. Separately, the spec might also need to be modified to say "only" active providers. Signed-off-by: Brandon Duffany <[email protected]>
sahidvelji
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement requirement 1.6.2 by having the
Shutdownfunction shut down only the registered providers and clean up all resources.Fixes #397