Replace custom alignment_of_long_double with _Alignof [v6.0.x] #13622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_Alignof was standardized in C11 which OMPI now requires. Signed-off-by: Joseph Schuchart <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR modernizes the codebase by replacing a custom alignment calculation function with the C11 standard _Alignof operator, which is now available since OMPI requires C11. This is a backport of PR #13613 to the v6.0.x branch.
Key changes:
- Removed the custom
alignment_of_long_double()function that computed alignment heuristically - Replaced all calls to this function with direct
_Alignof(long double)calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bosilca
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Alignof was standardized in C11 which OMPI now requires.
Backport of #13613 to v6.0.x