Skip to content

Replace custom alignment_of_long_double with _Alignof [v6.0.x] #13622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hppritcha merged 1 commit into from
Jan 8, 2026
Merged

Replace custom alignment_of_long_double with _Alignof [v6.0.x] #13622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions opal/datatype/opal_copy_functions_heterogeneous.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,31 +481,6 @@ f128_to_f80(unsigned char *f80_buf_to, const unsigned char *f128_buf_from, ssize
)
#define LDBL_INFO_MASK (OPAL_ARCH_LDMANTDIGISxx | OPAL_ARCH_LDEXPSIZEISxx)

#ifdef HAVE___FLOAT128
/*
* I'm not sure about the portability of alignof() so I'm handling things
* like the possibility of sizeof(long double) == 12 in a slower way. The
* alignment requirement in that case would be 4 (largest power of 2 that
* divides into the sizeof).
*
* And saving it static to just compute it once without running a loop
* every call.
*/
static inline
size_t
alignment_of_long_double(void) {
static size_t val = 0;

if (val == 0) {
val = 1;
while (sizeof(long double) % (val*2) == 0) {
val *= 2;
}
}
return val;
}
#endif

// ldbl_to_f128 (copies a long double(from_arch format) to a float128(local_endian))
static inline
void
Expand All @@ -515,7 +490,7 @@ ldbl_to_f128(unsigned char *f128_buf_to, const unsigned char *ldbl_buf_from, ssi
int ldbl_is_aligned;

ldbl_is_aligned = 1;
int alignment_mask = alignment_of_long_double() - 1;
int alignment_mask = _Alignof(long double) - 1;
if ((uintptr_t)ldbl_buf_from & alignment_mask) {
ldbl_is_aligned = 0;
}
Expand Down Expand Up @@ -576,7 +551,7 @@ f128_to_ldbl(unsigned char *ldbl_buf_to, const unsigned char *f128_buf_from, ssi
int ldbl_is_aligned;

ldbl_is_aligned = 1;
int alignment_mask = alignment_of_long_double() - 1;
int alignment_mask = _Alignof(long double) - 1;
if ((uintptr_t)ldbl_buf_to & alignment_mask) {
ldbl_is_aligned = 0;
}
Expand Down