Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for label limits specifically for label_limit, label_name_length_limit & label_value_length_limit configuration values for Prometheus Receiver #5997

Closed
3 tasks done
mustafain117 opened this issue Oct 29, 2021 · 1 comment · Fixed by #6430
Assignees
Labels
ci-cd CI, CD, testing, build issues comp:prometheus Prometheus related issues comp: receiver Receiver

Comments

@mustafain117
Copy link
Contributor

mustafain117 commented Oct 29, 2021

Is your feature request related to a problem? Please describe.
We want to ensure that Prometheus receiver honors label_limit, label_name_length_limit & label_value_length_limit configuration values.

Describe the solution you'd like
We propose the following solution:

  • Add one test for label_limit configuration
  • Add one test for label_name_length_limit configuration
  • Add one test for label_value_length_limit configuration

Each test will:

  • Set label_limit, label_name_length_limit & label_value_length_limit in the config for Prometheus receiver
  • For the positive test case, the prometheus receiver scrapes metrics which are within the defined limits for label_limit, label_name_length_limit & label_value_length_limit
    • Assert scrape is successful
  • For the negative test case, the prometheus receiver scrapes metrics which do not conform to the defined limits
    • for e.g metrics with number of labels greater than label_limit
    • Assert scrape is unsuccessful

Additional context
Related to: open-telemetry/wg-prometheus#57

CC: @alolita @Aneurysm9

@alolita alolita added comp:prometheus Prometheus related issues ci-cd CI, CD, testing, build issues comp: receiver Receiver labels Nov 2, 2021
@mustafain117
Copy link
Contributor Author

@alolita please assign this to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues comp:prometheus Prometheus related issues comp: receiver Receiver
Projects
None yet
2 participants