Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus Receiver test for label_limit configuration #6150

Merged

Conversation

mustafain117
Copy link
Contributor

Description:
Adds TestLabelLimitConfig to test label_limit configuration for Prometheus receiver

TestLabelLimitConfig:
Sets the label_limit for Prometheus receiver
Tests the following two scenarios:

  • Positive test case: Prometheus receiver scrapes metrics which are within the label_limit
    • Assert scrape is successful
  • Negative test case: Prometheus receiver scrapes metrics which exceed label_limit
    • Assert scrape is unsuccessful

Renamed metrics_reciever_external_labels_test.go to metrics_receiver_labels_test.go

Link to tracking Issue:
First of 3 PRs for issue #5997
Following 2 PRs will add tests for label_name_length_limit configuration & label_value_length_limit configuration

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 16, 2021
@alolita alolita added comp: receiver Receiver comp:prometheus Prometheus related issues and removed Stale labels Nov 17, 2021
@alolita
Copy link
Member

alolita commented Nov 17, 2021

@dashpole @vishiy can you provide a review? Then we should be ready to merge. Ty!!

@codeboten codeboten merged commit cb4cbd8 into open-telemetry:main Nov 19, 2021
povilasv referenced this pull request in coralogix/opentelemetry-collector-contrib Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:prometheus Prometheus related issues comp: receiver Receiver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants