Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update references to logging exporter #1528

Merged

Conversation

codeboten
Copy link
Contributor

This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested a review from a team as a code owner September 20, 2024 18:23
Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back! You should visit more often 😉

@@ -7,17 +7,17 @@ receivers:
endpoint: "localhost:4318"

exporters:
logging:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove an underlying dependency here to avoid a build failure in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future yes, I was going to leave that for now (as people transition away from it in their config)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I wasn't sure how quickly it was going to be removed.

@codeboten
Copy link
Contributor Author

Welcome back! You should visit more often 😉

Only so much time in the day 😅

@nslaughter
Copy link
Contributor

Thanks a bunch for this.

@tylerbenson tylerbenson merged commit 7c6351e into open-telemetry:main Sep 23, 2024
12 checks passed
@tylerbenson tylerbenson added the go Pull requests that update Go code label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants