Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update references to logging exporter #1528

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: update references to logging exporter #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions collector/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,16 @@ receivers:
grpc:

exporters:
logging:
loglevel: debug
debug:
verbosity: detailed
otlp:
endpoint: { backend endpoint }

service:
pipelines:
traces:
receivers: [otlp]
exporters: [logging, otlp]
exporters: [debug, otlp]
```

Once the file has been deployed with a Lambda, configuring the `OPENTELEMETRY_COLLECTOR_CONFIG_URI` will tell the OpenTelemetry extension where to find the collector configuration:
Expand Down
8 changes: 4 additions & 4 deletions collector/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ receivers:
endpoint: "localhost:4318"

exporters:
logging:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove an underlying dependency here to avoid a build failure in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future yes, I was going to leave that for now (as people transition away from it in their config)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I wasn't sure how quickly it was going to be removed.

loglevel: debug
debug:
verbosity: detailed

service:
pipelines:
traces:
receivers: [otlp]
exporters: [logging]
exporters: [debug]
metrics:
receivers: [otlp]
exporters: [logging]
exporters: [debug]
telemetry:
metrics:
address: localhost:8888
Loading