Add data migration to nullify target fields on bs_request_actions

[eduardoj]

Nullify target_project_id and target_package_id in bs_request_actions if the project or/and package no longer exist.

Follow-up to #17310.

[adrianschroeter]

On Montag, 3. Februar 2025, 11:17:56 CET Eduardo J. wrote: @eduardoj commented on this pull request. > @@ -0,0 +1,38 @@ +# frozen_string_literal: true + +class NullifyTargetsOnBsRequestActions < ActiveRecord::Migration[7.0] + # rubocop:disable Rails/SkipsModelValidations + def up + bs_request_actions = BsRequestAction.where('target_project_id IS NOT NULL AND target_package_id IS NULL') + bs_request_actions.in_batches do |batch| + batch.find_each do |action| + target_project = Project.find_by_name(action.target_project) Hm... Do we really want to skip remote projects?

you can never have a remote target project at least. Also, be sure not to loose informations. We must keep the information about the request source/target, even when the projects or packages get removed.

…

-- Adrian Schroeter ***@***.***> Build Infrastructure Project Manager SUSE Software Solutions Germany GmbH, Frankenstraße 146, 90461 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev

[eduardoj]

On Montag, 3. Februar 2025, 11:17:56 CET Eduardo J. wrote: @eduardoj commented on this pull request.

Hm... Do we really want to skip remote projects?

you can never have a remote target project at least.

Ok, then we are safe with applying Project.find_by(name: action.target_project)

Also, be sure not to loose informations. We must keep the information about the request source/target, even when the projects or packages get removed.

That information will be kept (and never touched) in the string fields source_project, source_package, target_project and target_package. The only fields which will be modified are source_project_id, source_package_id, target_project_id and target_package_id, for searching purposes. So we are safe there.