Update type hinting for DictList #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdiener
requested changes
Dec 3, 2025
src/cobra/core/dictlist.py
Outdated
|
|
||
|
|
||
| class DictList(list): | ||
| _TObject = TypeVar("_TObject", bound=Object) |
Member
There was a problem hiding this comment.
I would prefer a more descriptive name. Also does it need to be a hidden object?
For instance
CobraObject = TypeVar("CobraObject", bound=Object)looks clearer to me.
Contributor
Author
There was a problem hiding this comment.
Changing it from _TObject to CobraObject sounds good to me. I went ahead and updated it.
cdiener
approved these changes
Dec 3, 2025
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DictListclass by adding a TypeVar. This allows the specific type of object contained within an instantiatedDictListto be defined. For example, the type formodel.reactionsis nowDictList[Reaction]instead of justDictList. This means that now the hinted return type formodel.reactions.get_by_idisReactioninstead ofObject.