-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup old patch on envoyfilter #1699
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Wen Zhou <[email protected]>
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1699 +/- ##
=======================================
Coverage 21.98% 21.98%
=======================================
Files 168 168
Lines 11377 11376 -1
=======================================
Hits 2501 2501
+ Misses 8618 8617 -1
Partials 258 258 ☔ View full report in Codecov by Sentry. |
@@ -114,7 +114,6 @@ func defineServiceMeshFeatures(ctx context.Context, cli client.Client, dscispec | |||
manifest.Location(Resources.Location). | |||
Include( | |||
path.Join(Resources.ServiceMeshDir, "activator-envoyfilter.tmpl.yaml"), | |||
path.Join(Resources.ServiceMeshDir, "envoy-oauth-temp-fix.tmpl.yaml"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to cleanup existing RHOAI installation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it is fine to leave what it has been done.
it does not harm, but not needed for any newer version ossm (>=2.4) to have this patch.
we added it when 2.3 was still supported version, now even 2.4 will face EOL after next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danielezonca The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test opendatahub-operator-e2e |
Description
lets get the old patch cleaned up.
How Has This Been Tested?
Screenshot or short clip
Merge criteria