Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup old patch on envoyfilter #1699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: cleanup old patch on envoyfilter #1699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion controllers/components/kserve/kserve_support.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ func defineServiceMeshFeatures(ctx context.Context, cli client.Client, dscispec
manifest.Location(Resources.Location).
Include(
path.Join(Resources.ServiceMeshDir, "activator-envoyfilter.tmpl.yaml"),
path.Join(Resources.ServiceMeshDir, "envoy-oauth-temp-fix.tmpl.yaml"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to cleanup existing RHOAI installation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it is fine to leave what it has been done.
it does not harm, but not needed for any newer version ossm (>=2.4) to have this patch.

we added it when 2.3 was still supported version, now even 2.4 will face EOL after next week.

path.Join(Resources.ServiceMeshDir, "kserve-predictor-authorizationpolicy.tmpl.yaml"),
path.Join(Resources.ServiceMeshDir, "kserve-inferencegraph-envoyfilter.tmpl.yaml"),
path.Join(Resources.ServiceMeshDir, "kserve-inferencegraph-authorizationpolicy.tmpl.yaml"),
Expand Down
80 changes: 0 additions & 80 deletions controllers/components/kserve/resources/servicemesh/envoy-oauth-temp-fix.tmpl.yaml
View file
Open in desktop

This file was deleted.