Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: prepare feast to be enabled by default in ODH #1701

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Feb 27, 2025

DO NOT MERGE PR TILL feast-dev/feast#5047 IS MEREGED FIRST

Description

  • revert back d67f240e to test feast in e2e
  • set feast by default as managed component for ODH 2.26.0 release, we already have feast in ODH 2.24.0 2.25.0 for incubation

ref https://issues.redhat.com/browse/RHOAIENG-19100

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- revert back d67f240e to test feast in e2e
- set feast by default managed component

Signed-off-by: Wen Zhou <[email protected]>
Copy link

openshift-ci bot commented Feb 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@zdtsw zdtsw requested a review from redhatHameed February 27, 2025 09:06
Copy link

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw requested a review from ykaliuta February 27, 2025 09:06
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.18%. Comparing base (73d70b8) to head (92dad5e).

Files with missing lines Patch % Lines
pkg/upgrade/upgrade.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1701   +/-   ##
=======================================
  Coverage   22.18%   22.18%           
=======================================
  Files         168      168           
  Lines       11384    11384           
=======================================
  Hits         2526     2526           
  Misses       8600     8600           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant