Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: prepare feast to be enabled by default in ODH #1701

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

update: prepare feast to be enabled by default in ODH #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundle/manifests/opendatahub-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ metadata:
"managementState": "Managed"
},
"feastoperator": {
"managementState": "Removed"
"managementState": "Managed"
},
"kserve": {
"managementState": "Managed",
Expand Down
2 changes: 1 addition & 1 deletion config/samples/datasciencecluster_v1_datasciencecluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ spec:
managementState: "Managed"
registriesNamespace: "odh-model-registries"
feastoperator:
managementState: "Removed"
managementState: "Managed"
2 changes: 1 addition & 1 deletion pkg/upgrade/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
ManagementSpec: common.ManagementSpec{ManagementState: operatorv1.Managed},
},
FeastOperator: componentApi.DSCFeastOperator{
ManagementSpec: common.ManagementSpec{ManagementState: operatorv1.Removed},
ManagementSpec: common.ManagementSpec{ManagementState: operatorv1.Managed},

Check warning on line 97 in pkg/upgrade/upgrade.go

View check run for this annotation

Codecov / codecov/patch

pkg/upgrade/upgrade.go#L97 

Added line #L97 was not covered by tests
},
},
},
Expand Down
4 changes: 1 addition & 3 deletions tests/e2e/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,7 @@ var (
componentApi.KserveComponentName: kserveTestSuite,
componentApi.ModelMeshServingComponentName: modelMeshServingTestSuite,
componentApi.ModelControllerComponentName: modelControllerTestSuite,
// Temporary disable Feast until images are moved from docker.io
// TODO: enable when ready
// componentApi.FeastOperatorComponentName: feastOperatorTestSuite,
componentApi.FeastOperatorComponentName: feastOperatorTestSuite,
},
},
services: TestGroup{
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/feastoperator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
)

// TODO: remove unused when test enabled back.
func feastOperatorTestSuite(t *testing.T) { //nolint:unused
func feastOperatorTestSuite(t *testing.T) {
t.Helper()

ct, err := NewComponentTestCtx(&componentApi.FeastOperator{})
Expand Down