Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create items.js: creation/removal of items #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpg0
Copy link

@jpg0 jpg0 commented Oct 13, 2019

Port dynamic items creation/removal from python core libs

@5iver
Copy link
Member

5iver commented Dec 7, 2019

Thank you! Similar to the OH repos, I've been requiring sign-offs on commits... https://www.openhab.org/docs/developer/contributing.html#sign-your-work. You can either setup a local repo and use git to amend your commit, or close this PR and submit another (through the web) and include...

Signed-off-by: Joe Smith [email protected]

... at the bottom of the commit message.

Port dynamic items creation/removal from python core libs

Signed-off-by: Jonathan Gilbert <[email protected]>
@jpg0
Copy link
Author

jpg0 commented Dec 7, 2019

No worries; added the signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants