Skip to content

Conversation

hgqxjj
Copy link
Member

@hgqxjj hgqxjj commented Aug 25, 2025

This change refactors CPUTimeCounters::publish_gc_total_cpu_time() to use Atomic::xchg instead of a CAS (cmpxchg) loop.
Please review it. Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366035: Simplify CPUTimeCounters::publish_gc_total_cpu_time (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26921/head:pull/26921
$ git checkout pull/26921

Update a local copy of the PR:
$ git checkout pull/26921
$ git pull https://git.openjdk.org/jdk.git pull/26921/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26921

View PR using the GUI difftool:
$ git pr show -t 26921

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26921.diff

Using Webrev

Link to Webrev Comment

This change refactors CPUTimeCounters::publish_gc_total_cpu_time() to use Atomic::xchg instead of a CAS (cmpxchg) loop.
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2025

👋 Welcome back ghan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@hgqxjj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366035: Simplify CPUTimeCounters::publish_gc_total_cpu_time

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@hgqxjj The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime [email protected] rfr Pull request is ready for review labels Aug 25, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2025

Webrevs

@albertnetymk
Copy link
Member

/cc hotspot-gc

@openjdk openjdk bot added ready Pull request is ready to be integrated hotspot-gc [email protected] labels Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@albertnetymk
The hotspot-gc label was successfully added.

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hgqxjj
Copy link
Member Author

hgqxjj commented Aug 26, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 26, 2025
@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@hgqxjj
Your change (at version 6dd9ff8) is now ready to be sponsored by a Committer.

@hgqxjj
Copy link
Member Author

hgqxjj commented Aug 26, 2025

@albertnetymk @kimbarrett Thanks for your reviews! I’ve integrated this PR. Could you please sponsor it?

@albertnetymk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 26, 2025

Going to push as commit 2ae3ea2.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 26, 2025
@openjdk openjdk bot closed this Aug 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 26, 2025
@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@albertnetymk @hgqxjj Pushed as commit 2ae3ea2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants