Skip to content

8366035: Simplify CPUTimeCounters::publish_gc_total_cpu_time #26921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8366035: Simplify CPUTimeCounters::publish_gc_total_cpu_time #26921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b66b63
8366035: Simplify CPUTimeCounters::publish_gc_total_cpu_time
hgqxjj Aug 25, 2025
6dd9ff8
Update cpuTimeCounters.cpp
hgqxjj Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/hotspot/share/runtime/cpuTimeCounters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,9 @@ void CPUTimeCounters::inc_gc_total_cpu_time(jlong diff) {

void CPUTimeCounters::publish_gc_total_cpu_time() {
CPUTimeCounters* instance = CPUTimeCounters::get_instance();
// Ensure that we are only incrementing atomically by using Atomic::cmpxchg
// to set the value to zero after we obtain the new CPU time difference.
jlong old_value;
jlong fetched_value = Atomic::load(&(instance->_gc_total_cpu_time_diff));
// Atomically fetch the current _gc_total_cpu_time_diff and reset it to zero.
jlong new_value = 0;
do {
old_value = fetched_value;
fetched_value = Atomic::cmpxchg(&(instance->_gc_total_cpu_time_diff), old_value, new_value);
} while (old_value != fetched_value);
jlong fetched_value = Atomic::xchg(&(instance->_gc_total_cpu_time_diff), new_value);
get_counter(CPUTimeGroups::CPUTimeType::gc_total)->inc(fetched_value);
}

Expand Down