Conversation
jrobble
left a comment
There was a problem hiding this comment.
@jrobble made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @eric-mccann-pro).
docker-compose.components.yml line 228 at r1 (raw file):
build: ${OPENMPF_PROJECTS_PATH}/openmpf-components/python/QwenSpeechSummarization # TODO: Rename this to qwen-speech-summarization-server
Do what's mentioned in this TODO.
docker-compose.components.yml line 244 at r1 (raw file):
tty: true ipc: host # volumes:
Can we remove these fields?
tty: true
ipc: host
# volumes:
jrobble
left a comment
There was a problem hiding this comment.
@jrobble reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @eric-mccann-pro).
tstrass
left a comment
There was a problem hiding this comment.
@tstrass reviewed all commit messages and made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on eric-mccann-pro and jrobble).
docker-compose.components.yml line 226 at r3 (raw file):
<<: *component-base image: ${REGISTRY}openmpf_llm_speech_summarization:${TAG} build: ${OPENMPF_PROJECTS_PATH}/openmpf-components/python/LlmSpeechSummarization
Would we want this to depends_on the vllm server?
docker-compose.components.yml line 240 at r3 (raw file):
# - driver: nvidia # device_ids: ['0'] # capabilities: [gpu]
Why is resources commented out?
eric-mccann-pro
left a comment
There was a problem hiding this comment.
@eric-mccann-pro made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on jrobble and tstrass).
docker-compose.components.yml line 226 at r3 (raw file):
Previously, tstrass (Tom Strassner) wrote…
Would we want this to
depends_onthe vllm server?
Nope! It could be pointed at an external VLLM server and vllm starts up so slow that the latebound healthcheck keeps things cleaner IMO
docker-compose.components.yml line 240 at r3 (raw file):
Previously, tstrass (Tom Strassner) wrote…
Why is
resourcescommented out?
I think that was a robble decision. I think it's to have the file's contents be tailorable in the step where a user of the repo uses "docker compose config" to expand the templates and then choose which components they actually want to use
tstrass
left a comment
There was a problem hiding this comment.
@tstrass resolved 2 discussions.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on jrobble).
tstrass
left a comment
There was a problem hiding this comment.
@tstrass reviewed 1 file.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on eric-mccann-pro).
Issues:
Related PRs:
This change is