Skip to content

OCPBUGS-59627: Nutanix: Enable FeatureGate for MultiSubnet by default #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

abhay-nutanix
Copy link

Currently MultiSubnet support for Nutanix is behind a featureGate and is only available for dev and tech preview. So enabling featureGate for Nutanix and making is readily available to use on all ClusterProfiles

Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

Hello @abhay-nutanix! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 22, 2025
@openshift-ci-robot
Copy link

@abhay-nutanix: This pull request references Jira Issue OCPBUGS-59627, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Currently MultiSubnet support for Nutanix is behind a featureGate and is only available for dev and tech preview. So enabling featureGate for Nutanix and making is readily available to use on all ClusterProfiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei July 22, 2025 11:12
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 22, 2025
@openshift-ci openshift-ci bot requested review from deads2k and everettraven July 22, 2025 11:13
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhay-nutanix
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@everettraven
Copy link
Contributor

@JoelSpeed Looks like the verify-feature-promotion check passed having not detected any new default feature gates, which seems wrong.

@abhay-nutanix Could you provide a link to the Sippy test data that shows this feature has been properly tested to be promoted?

@JoelSpeed
Copy link
Contributor

check passed having not detected any new default feature gates, which seems wrong.

The code generation is incomplete, please run the update scripts and commit the result

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2025
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

@abhay-nutanix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift c36bb31 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn c36bb31 link true /test e2e-aws-ovn
ci/prow/e2e-aws-serial-2of2 c36bb31 link true /test e2e-aws-serial-2of2
ci/prow/verify c36bb31 link true /test verify
ci/prow/okd-scos-e2e-aws-ovn c36bb31 link false /test okd-scos-e2e-aws-ovn
ci/prow/verify-feature-promotion c36bb31 link true /test verify-feature-promotion
ci/prow/e2e-aws-serial-1of2 c36bb31 link true /test e2e-aws-serial-1of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@abhay-nutanix abhay-nutanix marked this pull request as draft July 23, 2025 05:18
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants