Skip to content

OCPBUGS-59627: Nutanix: Enable FeatureGate for MultiSubnet by default #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -324,15 +324,19 @@ spec:
is Name, and forbidden otherwise
rule: 'has(self.type) && self.type == ''Name'' ? has(self.name)
: !has(self.name)'
maxItems: 1
maxItems: 32
minItems: 1
type: array
x-kubernetes-list-type: atomic
x-kubernetes-validations:
- message: each subnet must be unique
rule: self.all(x, self.exists_one(y, x == y))
required:
- cluster
- name
- subnets
type: object
maxItems: 32
type: array
x-kubernetes-list-map-keys:
- name
Expand Down
3 changes: 2 additions & 1 deletion features.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
| MultiDiskSetup| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| MutatingAdmissionPolicy| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| NodeSwap| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| NutanixMultiSubnets| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| OVNObservability| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| PreconfiguredUDNAddresses| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| SELinuxMount| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down Expand Up @@ -92,6 +91,8 @@
| NetworkDiagnosticsConfig| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| NetworkLiveMigration| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| NetworkSegmentation| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| NutanixMultiSubnets| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| OnClusterBuild| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| OpenShiftPodSecurityAdmission| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| PinnedImages| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ProcMountType| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down
2 changes: 1 addition & 1 deletion features/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ var (
contactPerson("yanhli").
productScope(ocpSpecific).
enhancementPR("https://github.com/openshift/enhancements/pull/1711").
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

FeatureGateKMSEncryptionProvider = newFeatureGate("KMSEncryptionProvider").
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -606,15 +606,20 @@ spec:
when type is Name, and forbidden otherwise
rule: 'has(self.type) && self.type == ''Name''
? has(self.name) : !has(self.name)'
maxItems: 1
maxItems: 32
minItems: 1
type: array
x-kubernetes-list-type: atomic
x-kubernetes-validations:
- message: each subnet must be unique
rule: self.all(x, self.exists_one(y, x ==
y))
required:
- cluster
- name
- subnets
type: object
maxItems: 32
type: array
x-kubernetes-list-map-keys:
- name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ spec:
is Name, and forbidden otherwise
rule: 'has(self.type) && self.type == ''Name'' ? has(self.name)
: !has(self.name)'
maxItems: 1
maxItems: 32
minItems: 1
type: array
x-kubernetes-list-type: atomic
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ spec:
when type is Name, and forbidden otherwise
rule: 'has(self.type) && self.type == ''Name''
? has(self.name) : !has(self.name)'
maxItems: 1
maxItems: 32
minItems: 1
type: array
x-kubernetes-list-type: atomic
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@
{
"name": "NodeSwap"
},
{
"name": "NutanixMultiSubnets"
},
{
"name": "OVNObservability"
},
Expand Down Expand Up @@ -291,6 +288,12 @@
{
"name": "NetworkSegmentation"
},
{
"name": "NutanixMultiSubnets"
},
{
"name": "OnClusterBuild"
},
{
"name": "OpenShiftPodSecurityAdmission"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@
{
"name": "NodeSwap"
},
{
"name": "NutanixMultiSubnets"
},
{
"name": "OVNObservability"
},
Expand Down Expand Up @@ -291,6 +288,12 @@
{
"name": "NewOLM"
},
{
"name": "NutanixMultiSubnets"
},
{
"name": "OnClusterBuild"
},
{
"name": "OpenShiftPodSecurityAdmission"
},
Expand Down