Skip to content

Conversation

lance5890
Copy link
Contributor

The BoundServiceAccountTokenVolume is enabled by default

kind of post-cleanup of openshift/kubernetes#714 and #531

@openshift-ci openshift-ci bot requested review from atiratree and deads2k August 15, 2025 23:18
Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 15, 2025
@lance5890 lance5890 changed the title Use BoundServceAccountTokenVolume dy default OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default Aug 15, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 15, 2025
@openshift-ci-robot
Copy link

@lance5890: This pull request references Jira Issue OCPBUGS-60568, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The BoundServiceAccountTokenVolume is enabled by default

kind of post-cleanup of openshift/kubernetes#714 and #531

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lance5890
Copy link
Contributor Author

the related pr openshift/cluster-version-operator#660 will block the upgrade

need more investigation

@lance5890
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2025
@lance5890 lance5890 changed the title OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default WIP: OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default Aug 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2025
@lance5890
Copy link
Contributor Author

need to wait the openshift/cluster-version-operator#1225 to merge first

@lance5890 lance5890 changed the title WIP: OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default Aug 18, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants