-
Notifications
You must be signed in to change notification settings - Fork 205
OCPBUGS-60579: Suppuort automountServiceAccountToken modify #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OCPBUGS-60579: Suppuort automountServiceAccountToken modify #1225
Conversation
fix openshift#660 and openshift#607 Signed-off-by: lan.tian <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lance5890 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @lance5890. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@lance5890: This pull request references Jira Issue OCPBUGS-60579, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/ok-to-test |
9441c41
to
baeeb80
Compare
Signed-off-by: lan.tian <[email protected]>
baeeb80
to
9f94bdc
Compare
/retest |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
@lance5890: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@@ -22,7 +22,7 @@ spec: | |||
labels: | |||
k8s-app: cluster-version-operator | |||
spec: | |||
automountServiceAccountToken: false | |||
automountServiceAccountToken: false # removed in the next version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kube-api-access
mount point should also be removed in the next version
I noticed that @wking has tried to remove the
automountServiceAccountToken
in Revert "prevent pod deployment deadlock due to custom SA projected volume injection" #607 when upgrade to 4.9(this is not suppuorted when upgrade, because cvo do not suppuort remvoing theautomountServiceAccountToken
), and finally revert this in Bug 2005581: install/0000_00_cluster-version-operator_03_deployment: Explicit kube-api-access #660removing the
automountServiceAccountToken
not only needed by cvo, but also by OCPBUGS-60496: Use BoundServceAccountTokenVolume dy default cluster-kube-apiserver-operator#1896, and OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default cluster-kube-controller-manager-operator#858, and OCPBUGS-60572: Use BoundServceAccountTokenVolume dy default cluster-kube-scheduler-operator#571, and Use BoundServceAccountTokenVolume dy default library-go#2001removing the
automountServiceAccountToken
is ok when install a new cluster, but will encounter aerror: error creating clients: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable
issue because the cvo do not suppuort setting the newautomountServiceAccountToken
value (which will use the existing false value in the existing obj)maybe we should merge this PR first ,and then the related cluster operators
and finally remove the
automountServiceAccountToken
for cvo in the next upgrade version