Skip to content

Conversation

lance5890
Copy link
Contributor

@lance5890 lance5890 commented Aug 18, 2025

  1. I noticed that @wking has tried to remove the automountServiceAccountToken in Revert "prevent pod deployment deadlock due to custom SA projected volume injection" #607 when upgrade to 4.9(this is not suppuorted when upgrade, because cvo do not suppuort remvoing the automountServiceAccountToken), and finally revert this in Bug 2005581: install/0000_00_cluster-version-operator_03_deployment: Explicit kube-api-access #660

  2. removing the automountServiceAccountToken not only needed by cvo, but also by OCPBUGS-60496: Use BoundServceAccountTokenVolume dy default cluster-kube-apiserver-operator#1896, and OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default cluster-kube-controller-manager-operator#858, and OCPBUGS-60572: Use BoundServceAccountTokenVolume dy default cluster-kube-scheduler-operator#571, and Use BoundServceAccountTokenVolume dy default library-go#2001

  3. removing the automountServiceAccountToken is ok when install a new cluster, but will encounter a error: error creating clients: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable issue because the cvo do not suppuort setting the new automountServiceAccountToken value (which will use the existing false value in the existing obj)

  4. maybe we should merge this PR first ,and then the related cluster operators

  5. and finally remove the automountServiceAccountToken for cvo in the next upgrade version

Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign davidhurta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2025
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance5890 lance5890 changed the title Suppuort automountServiceAccountToken modify OCPBUGS-60579: Suppuort automountServiceAccountToken modify Aug 18, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 18, 2025
@openshift-ci-robot
Copy link
Contributor

@lance5890: This pull request references Jira Issue OCPBUGS-60579, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 18, 2025
@lance5890
Copy link
Contributor Author

/cc @vrutkovs @wking

@vrutkovs
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2025
@lance5890 lance5890 force-pushed the suppuort_automountServiceAccountToken branch from 9441c41 to baeeb80 Compare August 18, 2025 07:09
@lance5890 lance5890 force-pushed the suppuort_automountServiceAccountToken branch from baeeb80 to 9f94bdc Compare August 18, 2025 07:42
@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest-required

2 similar comments
@lance5890
Copy link
Contributor Author

/retest-required

@lance5890
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

@lance5890: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 9f94bdc link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -22,7 +22,7 @@ spec:
labels:
k8s-app: cluster-version-operator
spec:
automountServiceAccountToken: false
automountServiceAccountToken: false # removed in the next version.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kube-api-access mount point should also be removed in the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants