-
Notifications
You must be signed in to change notification settings - Fork 125
[release-4.19] OCPBUGS-55937: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cated. We inadvertently began serving these in the default feature set beginning with 4.17.0. We intend to stop serving them in 4.20.0 and to treat this as a typical deprecated API removal.
@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/retitle [release-4.19] OCPBUGS-55937: UPSTREAM: : Mark admissionregistration.k8s.io/v1beta1 as deprecated. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-55937, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@benluddy: This pull request references Jira Issue OCPBUGS-55937, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold |
/test ? |
@benluddy: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Will unhold once the relevant Cluster API changes are backported to 4.19 (https://issues.redhat.com/browse/OCPBUGS-55998). |
/jira refresh |
@benluddy: This pull request references Jira Issue OCPBUGS-55937, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The relevant Cluster API changes have been backported to 4.19 now. see PRs openshift/cluster-api#237, openshift/cluster-api-provider-aws#552 and openshift/cluster-capi-operator#291. |
/retest |
/jira refresh |
@wangke19: This pull request references Jira Issue OCPBUGS-55937, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@wangke19: This pull request references Jira Issue OCPBUGS-55937, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label backport-risk-assessed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/remove-label backports/unvalidated-commits
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
/payload-job ? |
The techpreview presubmit job was introduced in 4.20, doing a spot check here: /payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview /hold |
@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/421d8540-4634-11f0-8bbb-a95ea567867a-0 |
/hold cancel |
a36c41d
into
openshift:release-4.19
@openshift-cherrypick-robot: Jira Issue OCPBUGS-55937: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-55937 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: new pull request created: #2333 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
Fix included in accepted release 4.19.0-0.nightly-2025-06-17-144931 |
This is an automated cherry-pick of #2287
/assign benluddy
/cherrypick release-4.18