Skip to content

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2287

/assign benluddy

/cherrypick release-4.18

…cated.

We inadvertently began serving these in the default feature set beginning with 4.17.0. We intend to
stop serving them in 4.20.0 and to treat this as a typical deprecated API removal.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and tkashem May 7, 2025 23:43
@benluddy
Copy link

benluddy commented May 8, 2025

/retitle [release-4.19] OCPBUGS-55937: UPSTREAM: : Mark admissionregistration.k8s.io/v1beta1 as deprecated.

@openshift-ci openshift-ci bot changed the title [release-4.19] NO-JIRA: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. [release-4.19] OCPBUGS-55937: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. May 8, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 8, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-55937, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-55937 to depend on a bug targeting a version in 4.20.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2287

/assign benluddy

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@benluddy
Copy link

benluddy commented May 8, 2025

/jira refresh

@openshift-ci-robot
Copy link

@benluddy: This pull request references Jira Issue OCPBUGS-55937, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-55465 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@neisw
Copy link

neisw commented May 9, 2025

/hold
This was reverted in 4.20

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2025
@benluddy
Copy link

/test ?

Copy link

openshift-ci bot commented May 19, 2025

@benluddy: The following commands are available to trigger required jobs:

/test artifacts
/test configmap-scale
/test e2e-aws-crun-wasm
/test e2e-aws-jenkins
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-crun
/test e2e-aws-ovn-downgrade
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-runc
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade
/test e2e-azure-ovn-upgrade
/test e2e-gcp
/test e2e-gcp-ovn-upgrade
/test images
/test integration
/test k8s-e2e-conformance-aws
/test k8s-e2e-gcp-ovn
/test k8s-e2e-gcp-serial
/test perfscale-control-plane-6nodes
/test unit
/test verify
/test verify-commits

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-ovn
/test e2e-aws-single-node
/test e2e-azure
/test e2e-external-aws-ccm
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack
/test e2e-openstack-csi-cinder
/test e2e-openstack-csi-manila
/test e2e-vsphere
/test k8s-e2e-aws
/test k8s-e2e-aws-ovn-serial
/test k8s-e2e-gcp-five-control-plane-replicas
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-kubernetes-release-4.19-e2e-agnostic-ovn-cmd
pull-ci-openshift-kubernetes-release-4.19-e2e-aws-crun-wasm
pull-ci-openshift-kubernetes-release-4.19-e2e-aws-csi
pull-ci-openshift-kubernetes-release-4.19-e2e-aws-ovn-cgroupsv2
pull-ci-openshift-kubernetes-release-4.19-e2e-aws-ovn-crun
pull-ci-openshift-kubernetes-release-4.19-e2e-aws-ovn-fips
pull-ci-openshift-kubernetes-release-4.19-e2e-aws-ovn-hypershift
pull-ci-openshift-kubernetes-release-4.19-e2e-aws-ovn-runc
pull-ci-openshift-kubernetes-release-4.19-e2e-aws-ovn-serial
pull-ci-openshift-kubernetes-release-4.19-e2e-gcp
pull-ci-openshift-kubernetes-release-4.19-e2e-gcp-ovn-upgrade
pull-ci-openshift-kubernetes-release-4.19-images
pull-ci-openshift-kubernetes-release-4.19-integration
pull-ci-openshift-kubernetes-release-4.19-k8s-e2e-aws-ovn-serial
pull-ci-openshift-kubernetes-release-4.19-k8s-e2e-conformance-aws
pull-ci-openshift-kubernetes-release-4.19-k8s-e2e-gcp-ovn
pull-ci-openshift-kubernetes-release-4.19-k8s-e2e-gcp-serial
pull-ci-openshift-kubernetes-release-4.19-okd-scos-e2e-aws-ovn
pull-ci-openshift-kubernetes-release-4.19-unit
pull-ci-openshift-kubernetes-release-4.19-verify
pull-ci-openshift-kubernetes-release-4.19-verify-commits

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@benluddy
Copy link

Will unhold once the relevant Cluster API changes are backported to 4.19 (https://issues.redhat.com/browse/OCPBUGS-55998).

@benluddy
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@benluddy: This pull request references Jira Issue OCPBUGS-55937, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-55465 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Jira Issue OCPBUGS-55944 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link

wangke19 commented Jun 4, 2025

The relevant Cluster API changes have been backported to 4.19 now. see PRs openshift/cluster-api#237, openshift/cluster-api-provider-aws#552 and openshift/cluster-capi-operator#291.
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2025
@wangke19
Copy link

wangke19 commented Jun 4, 2025

/retest

@wangke19
Copy link

wangke19 commented Jun 4, 2025

/jira refresh

@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-55937, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link

wangke19 commented Jun 4, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 4, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-55937, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-55944 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-55944 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 5, 2025
@bertinatto
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 10, 2025
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label backports/unvalidated-commits

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 10, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fadb78e and 2 for PR HEAD fe91d28 in total

Copy link

openshift-ci bot commented Jun 10, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-gcp-serial fe91d28 link unknown /test k8s-e2e-gcp-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@benluddy
Copy link

/retest

@benluddy
Copy link

/payload-job ?

Copy link

openshift-ci bot commented Jun 10, 2025

@benluddy: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@benluddy
Copy link

The techpreview presubmit job was introduced in 4.20, doing a spot check here:

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2025
Copy link

openshift-ci bot commented Jun 10, 2025

@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/421d8540-4634-11f0-8bbb-a95ea567867a-0

@benluddy
Copy link

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a36c41d into openshift:release-4.19 Jun 16, 2025
22 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-55937: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55937 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2287

/assign benluddy

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

@openshift-cherrypick-robot: new pull request created: #2333

In response to this:

This is an automated cherry-pick of #2287

/assign benluddy

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.19.0-202506161416.p0.ga36c41d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.19.0-202506161416.p0.ga36c41d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.19.0-202506161416.p0.ga36c41d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.19.0-202506161416.p0.ga36c41d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.19.0-0.nightly-2025-06-17-144931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.