[release-4.18] OCPBUGS-57488: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. #2333
Conversation
…cated. We inadvertently began serving these in the default feature set beginning with 4.17.0. We intend to stop serving them in 4.20.0 and to treat this as a typical deprecated API removal.
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-55937 has been cloned as Jira Issue OCPBUGS-57488. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-57488, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
openshift-ci
bot
added
approved
sdodson
added
jira/valid-bug
|
Marked this as jira/valid-bug because it'd be beneficial to get this part into 4.18 ASAP so that we begin counting and letting people know about the removal ASAP. The 4.19 bug is doing more work than this but this one can go on its own. Just needs lgtm. /label backport-risk-assessed cherry-pick-approved |
|
Should this be packported all the way down to 4.17? /assign @benluddy /retest-required |
We'd been thinking no, since 4.18 is enough to give us the eus-to-eus removal alert. |
|
/hold /payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview /cc @JoelSpeed Are the CAPI components still using this GV in 4.18? |
openshift-ci
bot
added
the
do-not-merge/hold
|
@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/43ea5990-52b7-11f0-9356-bcacd5d8ad6f-0 |
|
|
/hold I haven't completed the removal of this GV for 4.18 |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/27605f50-777d-11f0-87c9-d5c5ee70f40d-0 |
|
/payload-abort |
|
/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview |
|
@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a8b532b0-777d-11f0-92b9-f7fcd7b35093-0 |
|
/assign @bertinatto @JoelSpeed confirmed today that the remaining 4.18 v1beta1 clients are now using v1. The techpreview payload job looks OK. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, openshift-cherrypick-robot, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label backport-risk-assessed |
|
@benluddy: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sdodson
added
the
backport-risk-assessed
openshift-ci
bot
assigned
duanwei33,
gangwgr,
kasturinarra,
lyman9966,
wangke19 and
xingxingxia
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit d3330e0
into
openshift:release-4.18
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-57488: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-57488 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@benluddy We also have code change of openshift/cluster-version-operator#1193 for 4.19. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
|
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
The ack is only necessary to protect the 4.19 to 4.20 upgrade. Since the GV is still served in 4.19, even on clusters with a workload that depends on it, no action is required before the 4.18 to 4.19 upgrade. |
This is an automated cherry-pick of #2290
/assign openshift-cherrypick-robot