Fix blog CTA button text not displaying #2812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit font-size to blog CTA buttons to match flex-page CTA styling. The button mixin includes a font style, but adding body-font(2rem) ensures the text is visible and matches the styling used in other CTA blocks. Fixes CORE-1410 Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The CMS API automatically converts snake_case field names to camelCase when the frontend loads the data. Updated the CTA component to use buttonHref and buttonText (camelCase) instead of button_href and button_text (snake_case) to match the transformed API data. This fixes both the button text and href not displaying properly. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The CTA component was updated to use camelCase field names (buttonText, buttonHref) to match the API response format. This updates the test to use the same field names. Fixes test failures in body-units.test.tsx 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Fix test data in article-page-data.js to use buttonText and buttonHref instead of button_text and button_href to match the component changes. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
RoyEJohnson
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the blog CTA button text not displaying issue reported in CORE-1410.
Changes
@include body-font(2rem)to the.blog-cta .btnselector inarticle.scssIssue
The blog CTA button was rendering correctly (orange button with proper dimensions) but the text inside was not visible, even though the JSON data contained the correct
button_textvalue.Root Cause
The button was missing an explicit font-size declaration. While the
@include button()mixin includes@include set-font(body-regular), adding the explicit@include body-font(2rem)ensures the text renders properly, matching the approach used in other CTA implementations (flex-page CTAs).Testing
Related to: CORE-1410